Bug-v.2.6.16-categories' menu problem : fully expanded and f

Please report bugs here!

Moderator: Thorsten

Post Reply
pt20100201
Posts: 134
Joined: Mon Feb 01, 2010 2:11 pm
Location: Porto . Portugal
Contact:

Bug-v.2.6.16-categories' menu problem : fully expanded and f

Post by pt20100201 »

.
Bug-v.2.6.16-categories' menu problem : fully expanded and "flat"

Dear Thorsten

Today, we upgraded phpMyFAQ's version 2.6.15 to v. 2.6.16.

However - after detecting a problem - we were forced to downgrade to the initial version.

There is a bug in the categories navigation area: the menu is fully expanded and is "flat" (there is no distinction between the different levels).

As you may see in the screenshots included on the attached file
pt20100201-20110601-screenshots-cat-v-2.6.15-ok+2.6.16-wrong.7z ,
  • it doesn’t happen with 2.6.15 version;
  • categories’ structure is displayed correctly in the v.2.6.16 administration interface.
We kept the “upgraded” database.


Kind regards

2011-06-01
pt20100201
.
Attached file : pt20100201-20110601-screenshots-cat-v-2.6.15-ok+2.6.16-wrong.7z
.
You do not have the required permissions to view the files attached to this post.
tigerlinux
Posts: 24
Joined: Thu Jun 02, 2011 2:11 pm

Re: Bug-v.2.6.16-categories' menu problem : fully expanded a

Post by tigerlinux »

pt20100201 wrote:.
Bug-v.2.6.16-categories' menu problem : fully expanded and "flat"

Dear Thorsten

Today, we upgraded phpMyFAQ's version 2.6.15 to v. 2.6.16.

However - after detecting a problem - we were forced to downgrade to the initial version.

There is a bug in the categories navigation area: the menu is fully expanded and is "flat" (there is no distinction between the different levels).

As you may see in the screenshots included on the attached file
pt20100201-20110601-screenshots-cat-v-2.6.15-ok+2.6.16-wrong.7z ,
  • it doesn’t happen with 2.6.15 version;
  • categories’ structure is displayed correctly in the v.2.6.16 administration interface.
We kept the “upgraded” database.


Kind regards

2011-06-01
pt20100201
.
Attached file : pt20100201-20110601-screenshots-cat-v-2.6.15-ok+2.6.16-wrong.7z
.
Detected exactly the same problem after the upgrade, but I was able to apply a temporary solution by using a file from the previous version (2.6.15). The file is:

inc/Category.php

In the "CHANGEDFILES" under "docs" that file is one of the changed ones from v 2.6.15 to 2.6.16. I replaced it with the one from 2.6.15 and the view is again in "tree" mode as expected. If you are going to try this, first make a backup of your actual "inc/Category.php" file. Good luck !.

Best regards,

Reynaldo Martinez
CCS, Venezuela.
pt20100201
Posts: 134
Joined: Mon Feb 01, 2010 2:11 pm
Location: Porto . Portugal
Contact:

Re: Bug-v.2.6.16-categories' menu problem : fully expanded a

Post by pt20100201 »

.
Dear Reynaldo Martinez
tigerlinux wrote:
pt20100201 wrote:.
Bug-v.2.6.16-categories' menu problem : fully expanded and "flat"

Dear Thorsten
...
There is a bug in the categories navigation area: the menu is fully expanded and is "flat" (there is no distinction between the different levels).
...
2011-06-02
pt20100201
...
Detected exactly the same problem after the upgrade, but I was able to apply a temporary solution by using a file from the previous version (2.6.15). The file is:

inc/Category.php

In the "CHANGEDFILES" under "docs" that file is one of the changed ones from v 2.6.15 to 2.6.16. I replaced it with the one from 2.6.15 and the view is again in "tree" mode as expected. If you are going to try this, first make a backup of your actual "inc/Category.php" file. Good luck !.

Best regards,

Reynaldo Martinez
CCS, Venezuela.
Thanks for your message.

We followed your instructions with a positive result: now v. 2.6.16 is working.

Once again, thank for your help.

Kind regards

2011-06-01
pt20100201
.
Thorsten
Posts: 15560
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: Bug-v.2.6.16-categories' menu problem : fully expanded a

Post by Thorsten »

Hi,

we already reverted this issue, 2.6.17 will be available quite soon to fix this annoying issue. Sorry for that.

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
pt20100201
Posts: 134
Joined: Mon Feb 01, 2010 2:11 pm
Location: Porto . Portugal
Contact:

Re[2]: Bug-v.2.6.16-categories' menu problem : fully expande

Post by pt20100201 »

.
Re[2]: Bug-v.2.6.16-categories' menu problem : fully expanded a
.
Hi,

Some feedback for Reynaldo Martinez and Thorsten Rinne.
Thorsten wrote:we already reverted this issue, 2.6.17 will be available quite soon to fix this annoying issue. Sorry for that.
Thanks for your reply.

After the very useful Reynaldo Martinez's help, knowing the problematic file we run today a diff between Category.php on phpMyFAQ versions 2.6.15 + 2.6.16, and
  • changed the 2.6.16 version affected lines to those on the previous one;
  • kept the new line introduced on version 2.6.16;
  • replaced the old .htaccess file with the new _.htaccess content (after editing it, naturally).
It seems to be working - like the initial solution.

Diff results (Category.php v.2.6.15 / 2.6.16)

Code: Select all

226c226
<             $this->categories[] =& $this->categoryName[$row['id']];
---
>             $this->categories[] = $this->categoryName[$row['id']];
254c254
<         foreach (explode(';', $categories) as $cats) {
---
>         foreach (explode(',', $categories) as $cats) {
747a748
>         $oLink->id        = 'category_' . $categoryId;

Regards

2011-06-07
pt20100201
.
Thorsten
Posts: 15560
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: Bug-v.2.6.16-categories' menu problem : fully expanded a

Post by Thorsten »

Hi,

with this solution you'll have an issue for moving categories in the admin backend. Here are my fixes:

https://github.com/thorsten/phpMyFAQ/commits/2.6

I'll release 2.6.17 tomorrow if I'll find time.

Thanks!

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
pt20100201
Posts: 134
Joined: Mon Feb 01, 2010 2:11 pm
Location: Porto . Portugal
Contact:

Re[3]: Bug-v.2.6.16-categories' menu problem : fully expande

Post by pt20100201 »

.
Re[3]: Bug-v.2.6.16-categories' menu problem
.
Dear Thorsten
Thorsten wrote:with this solution you'll have an issue for moving categories in the admin backend. Here are my fixes:
...
I'll release 2.6.17 tomorrow if I'll find time.
Thank for taking your limited time to reply.

We tested only the navigation issue.
We'll then wait for 2.6.17 version.

Please continue your good work.


Kind regards

2011-06-08
pt20100201
.
Post Reply