Configuration not saving

Please report bugs here!

Moderator: Thorsten

rudibr78
Posts: 2
Joined: Fri Apr 28, 2017 1:26 pm

Re: Configuration not saving

Post by rudibr78 » Fri Apr 28, 2017 1:31 pm

Hello

I started using phpmyfaq today and also run into this trouble.

There's a bug where the request token for the form submission gets reset.
I haven't been able to fix it, but I did manage to workaround it.

If you want to apply this temporary fix, edit file admin/configuration.php and change line 37 from

Code: Select all

if ('saveConfig' === $userAction && $currentToken === $csrfToken) {
to

Code: Select all

if ('saveConfig' === $userAction) {
this way the token validation gets ignored and you can save the configs

Thorsten
Posts: 14434
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: Configuration not saving

Post by Thorsten » Sun May 07, 2017 7:39 am

Hi,

with this change you're creating a possible security issue.

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist

User
Posts: 8
Joined: Tue Sep 13, 2016 11:34 am

Re: Configuration not saving

Post by User » Sun May 07, 2017 9:38 am

Thorsten wrote:
Sun May 07, 2017 7:39 am
with this change you're creating a possible security issue.
So your solution is not to save configuration for better security?

LOL

JochenS
Posts: 120
Joined: Wed Feb 16, 2011 3:51 pm
Location: Schönaich
Contact:

Re: Configuration not saving

Post by JochenS » Wed May 10, 2017 1:26 pm

I can reproduce it my system with 2.9.7.

The problem is visible if the automatic content negotiation of the browser language detects de-de, but the main language is English.
Workaround is to switch inthe backend to the database language.

I have another FAQ with main laguage German and here the backend saves the result if backend language is set to Deutsch..

Thorsten
Posts: 14434
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: Configuration not saving

Post by Thorsten » Thu May 11, 2017 7:11 pm

Hi Jochen,

good to see you back again. I cannot reproduce the issue... tested with latest Chrome, configured with DE-DE, on a FAQ in English. Is it possible to get access to your FAQ?

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist

JochenS
Posts: 120
Joined: Wed Feb 16, 2011 3:51 pm
Location: Schönaich
Contact:

Re: Configuration not saving

Post by JochenS » Fri May 12, 2017 12:53 pm

Yes, It is fun to have more time on phpMyFAQ. We are moving to an server in the enterprize system. I can provide access with Teamviewer from my PC. Monday or Tuesday afternoon next week?

Thorsten
Posts: 14434
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: Configuration not saving

Post by Thorsten » Fri May 12, 2017 7:11 pm

Hi,

next week I'm on a business trip on monday and tuesday.

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest