only show login fields when connecting via HTTPS

You have a suggestion for a future version of phpMyFAQ? Then post it here!

Moderator: Thorsten

Post Reply
insecure
Posts: 8
Joined: Sun Sep 06, 2009 12:52 pm

only show login fields when connecting via HTTPS

Post by insecure » Mon Sep 07, 2009 8:30 pm

Since it is insecure to send authentication credentials via an unencrypted connection, I patched my installation of phpmyfaq 2.5.2 to only show the loginfields if connected via HTTPS. If you are connected via HTTP only, you will only see a link, which points to the HTTPS version of the current view.
I attached a patch, just for the case anybody is interested.
You do not have the required permissions to view the files attached to this post.

Thorsten
Posts: 14722
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: only show login fields when connecting via HTTPS

Post by Thorsten » Tue Sep 08, 2009 4:41 am

Hi,

nice patch... but most people don't have the chance to use https... I could add this as option, what do you think?

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist

insecure
Posts: 8
Joined: Sun Sep 06, 2009 12:52 pm

Re: only show login fields when connecting via HTTPS

Post by insecure » Tue Sep 08, 2009 8:50 pm

Would be nice to have this in the next version.

I didn't know there are still people out there who can't use HTTPS. That's quite strange, but they probably have accounts at some strange webhosters. ;-)

I also would make this patch complete, but I don't have time at the moment to make it good enough.

insecure
Posts: 8
Joined: Sun Sep 06, 2009 12:52 pm

Re: only show login fields when connecting via HTTPS

Post by insecure » Tue Sep 08, 2009 10:47 pm

Hmm, OK, I improved my patch. (Seems I found time for this after all. ;-)) This may need some improvement, but it seems to work. The patch contains the german and englisch translations, the patched initial sql-table files and has support for the configuration menu.
You do not have the required permissions to view the files attached to this post.

Thorsten
Posts: 14722
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: only show login fields when connecting via HTTPS

Post by Thorsten » Wed Sep 09, 2009 12:22 pm

Hi,

thanks for the patch, it's implemented in phpMyFAQ 2.6.0-alpha. Is it okay to add your name in the changelog?

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist

insecure
Posts: 8
Joined: Sun Sep 06, 2009 12:52 pm

Re: only show login fields when connecting via HTTPS

Post by insecure » Wed Sep 09, 2009 12:45 pm

Yes, of course you can add my name (Tobias Hommel) to the changelog.

Thorsten
Posts: 14722
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: only show login fields when connecting via HTTPS

Post by Thorsten » Fri Nov 13, 2009 12:22 pm

Hi,

released to public in 2.6.0-alpha.

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist

Post Reply