Search found 19 matches

by bram
Thu Aug 26, 2010 8:38 am
Forum: Bug reports
Topic: [PATCH] Update version check in install/setup.php
Replies: 1
Views: 1852

[PATCH] Update version check in install/setup.php

Attached is a patch that moves the version check in install/setup.php and install/update.php.

That is: first check the version and then load the extra files such as constants.php (which may be using a new php feature)

Note: this patch was not tested very extensively.
by bram
Thu Aug 26, 2010 8:00 am
Forum: Webserver and configuration
Topic: Error when trying to install the 2.x branch
Replies: 24
Views: 21455

Re: Error when trying to install the 2.x branch

Once again you are wrong and continue to make all the wrong assumptions. As you can see here, the version of my PHP is a very recently updated 8/2010 install of version of 5. Can you try to go to /install/setup.php? Does it show an error? (What error?) Also: what is the name of the file you used to...
by bram
Thu Aug 26, 2010 7:56 am
Forum: Webserver and configuration
Topic: Error when trying to install the 2.x branch
Replies: 24
Views: 21455

Re: Error when trying to install the 2.x branch

Once again you are wrong and continue to make all the wrong assumptions. As you can see here, the version of my PHP is a very recently updated 8/2010 install of version of 5. Can you try to go to /install/setup.php? Does it show an error? (What error?) Also: what is the name of the file you used to...
by bram
Tue Aug 24, 2010 4:24 pm
Forum: Bug reports
Topic: [PATCH] Postgresql: warnings when inserting a backslash
Replies: 1
Views: 2267

[PATCH] Postgresql: warnings when inserting a backslash

Short version: In the default postgres 'standard_conforming_strings' is set to off. This causes pg_escape to change a string which contains a backslash to two backslashes. (That is: from ' foo\ bar' into 'foo \\ bar') This then updates the database with the correct data but a warning is shown in the...
by bram
Tue Aug 24, 2010 8:48 am
Forum: Bug reports
Topic: Database Reconnect failure, PMF 2.6.5
Replies: 3
Views: 7271

Re: Database Reconnect failure, PMF 2.6.5

The most likely reason that this happens is because you have pgsql.auto_reset_persistent set to Off. This causes php to reuse the connection without testing if the connection is still alive/active. When something happend on the database server that closes the connection (restart of database, idle ti...
by bram
Thu Aug 19, 2010 8:09 am
Forum: General discussions
Topic: Moving categories
Replies: 1
Views: 1646

Moving categories

This is not a real bug reports just some remarks about the moving categories code. Currently the swapCategories code in inc/Category.php / inc/PMF_Category/Helper.php does: a) create a random id between 200000 and 400000 b) update the id1 in faqcategories with the random id c) update the id2 in faqc...
by bram
Thu Aug 19, 2010 7:58 am
Forum: Bug reports
Topic: V2.6.2 : Undefined index: in Category.php
Replies: 12
Views: 10563

Re: V2.6.2 : Undefined index: in Category.php

A patch that fixes the warnings is attached. Note that is is not a real fix. Normally the title shows: "Main-category: sub-category: question" When the user has access to the sub-category and not to the main-category then the title shows ": question" and 3 warnings are generated. After the patch the...
by bram
Thu Aug 19, 2010 7:40 am
Forum: Bug reports
Topic: [PATCH] Improve the error handler
Replies: 3
Views: 2480

Re: [PATCH] Improve the error handler

I noticed that I made a mistake in the patch...

My patch uses

Code: Select all

 printf ($errorMessage);
which is not correct.
It should be:

Code: Select all

 printf ("%s", $errorMessage);
or

Code: Select all

 print ($errorMessage);
by bram
Tue Aug 17, 2010 9:43 am
Forum: Proposals
Topic: Configure minimum length of a username
Replies: 1
Views: 3784

Configure minimum length of a username

Currently the minimum length of a username is hard coded and is not configurable. This is set in 3 places: 1. inc/User.php (private $login_minLength = 4;) 2. register.php ($loginMinLength = 4;) 3. admin/User.php ($loginMinLength = 4;) In addition to that there is a regex in inc/User.php that (inidir...
by bram
Tue Aug 17, 2010 9:00 am
Forum: Bug reports
Topic: [PATCH] GIT: Undefined variable when moving categories
Replies: 1
Views: 1732

[PATCH] GIT: Undefined variable when moving categories

In the GIT head it appears an undefined variable is used when moving categories. in phpmyfaq/inc/PMF_Category/Helper.php: public function swapCategories($firstCategoryId, $secondCategoryId) { $temp_cat = rand(200000, 400000); $tables = array( array('faqcategories' => 'id'), array('faqcategories' => ...
by bram
Tue Aug 17, 2010 8:55 am
Forum: Bug reports
Topic: Error when moving a category in postgresql 8.4.2
Replies: 1
Views: 2001

Error when moving a category in postgresql 8.4.2

When postgresql 8.4.2 is used and a category is moved then there is an error: PHP warning: pg_query() [<a href='function.pg-query'>function.pg-query</a>]: Query failed: ERROR: operator does not exist: character varying = integer LINE 1: ...E faqquestions SET ask_rubrik = 209373 WHERE ask_rubrik = 39...
by bram
Tue Aug 17, 2010 8:21 am
Forum: Bug reports
Topic: [PATCH] use of undefined variable
Replies: 1
Views: 1733

[PATCH] use of undefined variable

Attached is a patch to fix the use of an undefined variable: PHP notice: Undefined variable: cat in category.translate.php on line 70 PHP notice: Trying to get property of non-object in category.translate.php on line 70 This is a patch for 2.6.7 and not for the git head. (in the git head this is fix...
by bram
Mon Aug 16, 2010 4:48 pm
Forum: Bug reports
Topic: [PATCH] Errors when editing/adding a faq that is not in a ca
Replies: 1
Views: 1870

[PATCH] Errors when editing/adding a faq that is not in a ca

NOTE: I'm not sure if this patch is still relevant since the code appears to be changed between 2.6.7 and the HEAD in git... When editing a FAQ that was not added in a category I got the errors: * PHP recoverable error: Argument 1 passed to PMF_Faq::addCategoryRelations() must be an array, null give...
by bram
Mon Aug 16, 2010 4:47 pm
Forum: Bug reports
Topic: [PATCH] Warnings when exporting an empty category to PDF/exp
Replies: 1
Views: 1809

[PATCH] Warnings when exporting an empty category to PDF/exp

Currently there are warnings when an empty category is exported to PDF: - PHP notice: Undefined index: XXX in Wrapper.php on line 416 => Fix this by always setting the category id and name There are also warnings when an faq that is not in a category is exported to PDF: (the faq was returned by a se...
by bram
Mon Aug 16, 2010 4:46 pm
Forum: Bug reports
Topic: [PATCH] Silence warnings in admin/record_edit.php
Replies: 1
Views: 1664

[PATCH] Silence warnings in admin/record_edit.php

Currently admin/record_edit.php generated warnings in some conditions: - Undefined offset: XXX in record.edit.php on line 329 - Undefined offset: XXX in record.edit.php on line 354 Attached is patch that silence the warnings (0005-Silence-warnings.patch). NOTE: this patch was originally written on 2...