When working w/PMF 2.6.5 and creating a FAQ any clicking on either of the 'Changelog' links at the bottom immediately cause the browser to jump to the top of the screen. I believe this is because the id being selected by the JavaScript does not exist so it just heads to the top as a last resort. This happens in both Firefox 3.5.9 (OpenSUSE 11.2 x86_64) and Google Chrome 5.0.375.55.
<legend><a href="#" onclick="javascript:toggleFieldset('Changelog');">Changelog</a></legend>
<div id="editChangelog" style="display: none;">
<legend><a href="#" onclick="javascript:toggleFieldset('ChangelogHistory');">Changelog</a></legend>
<div id="editChangelogHistory" style="display: none;">
I'll be working on fixing this later in my setup but knowing it was reported would be comforting.
Thanks.
Jump to top of page on Changelog click, PMF 2.6.5
Moderator: Thorsten
Re: Jump to top of page on Changelog click, PMF 2.6.5
Um.... errr....... no. My initial analysis was completely wrong since the JS function actually adds 'edit' on the beginning. Still looking for something valid.....
Re: Jump to top of page on Changelog click, PMF 2.6.5
Hi,
here's the fix: http://github.com/thorsten/phpMyFAQ/com ... 662391e6f5
Thanks for the hint!
bye
Thorsten
here's the fix: http://github.com/thorsten/phpMyFAQ/com ... 662391e6f5
Thanks for the hint!
bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
amazon.de Wishlist
Re: Jump to top of page on Changelog click, PMF 2.6.5
Perfect. Thank-you for that fix.
Re: Jump to top of page on Changelog click, PMF 2.6.5
The three links in the body on the 'Configuration' page within the administrative interface also have this same problem. The same fix resolves things:
<diff file='./phpmyfaq/admin/configuration.php' version='2.6.5'>
82c82
< <legend><a href="#" onclick="javascript:toggleConfig('Main');"><?php print $PMF_LANG['mainControlCenter']; ?></a></legend>
---
> <legend><a href="javascript:void(0);" onclick="javascript:toggleConfig('Main');"><?php print $PMF_LANG['mainControlCenter']; ?></a></legend>
86c86
< <legend><a href="#" onclick="javascript:toggleConfig('Records');"><?php print $PMF_LANG['recordsControlCenter']; ?></a></legend>
---
> <legend><a href="javascript:void(0);" onclick="javascript:toggleConfig('Records');"><?php print $PMF_LANG['recordsControlCenter']; ?></a></legend>
90c90
< <legend><a href="#" onclick="javascript:toggleConfig('Spam');"><?php print $PMF_LANG['spamControlCenter']; ?></a></legend>
---
> <legend><a href="javascript:void(0);" onclick="javascript:toggleConfig('Spam');"><?php print $PMF_LANG['spamControlCenter']; ?></a></legend>
</diff>
Thanks.
<diff file='./phpmyfaq/admin/configuration.php' version='2.6.5'>
82c82
< <legend><a href="#" onclick="javascript:toggleConfig('Main');"><?php print $PMF_LANG['mainControlCenter']; ?></a></legend>
---
> <legend><a href="javascript:void(0);" onclick="javascript:toggleConfig('Main');"><?php print $PMF_LANG['mainControlCenter']; ?></a></legend>
86c86
< <legend><a href="#" onclick="javascript:toggleConfig('Records');"><?php print $PMF_LANG['recordsControlCenter']; ?></a></legend>
---
> <legend><a href="javascript:void(0);" onclick="javascript:toggleConfig('Records');"><?php print $PMF_LANG['recordsControlCenter']; ?></a></legend>
90c90
< <legend><a href="#" onclick="javascript:toggleConfig('Spam');"><?php print $PMF_LANG['spamControlCenter']; ?></a></legend>
---
> <legend><a href="javascript:void(0);" onclick="javascript:toggleConfig('Spam');"><?php print $PMF_LANG['spamControlCenter']; ?></a></legend>
</diff>
Thanks.
Re: Jump to top of page on Changelog click, PMF 2.6.5
Hi,
thank you very much, fixed for 2.6.6.
bye
Thorsten
thank you very much, fixed for 2.6.6.
bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
amazon.de Wishlist