href not re-writing URL

Please report bugs here!

Moderator: Thorsten

Post Reply
solarpenguin
Posts: 2
Joined: Tue Jul 03, 2018 10:30 pm

href not re-writing URL

Post by solarpenguin »

I've tested this on my system and two of the demo environments with the same result. When creating an on page href and anchor, the resulting url is not taking into account the query.

For the following articles:
http://jen.demo.phpmyfaq.de/index.php?a ... artlang=en
http://paul.demo.phpmyfaq.de/index.php? ... artlang=en

the href is writing this:
http://jen.demo.phpmyfaq.de/#anchor
http://paul.demo.phpmyfaq.de/#anchor

but should be writing this:
http://jen.demo.phpmyfaq.de/index.php?a ... =en#anchor
http://paul.demo.phpmyfaq.de/index.php? ... =en#anchor

Please help!
Thorsten
Posts: 15373
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: href not re-writing URL

Post by Thorsten »

Hi,

I created an issue for this: https://github.com/thorsten/phpMyFAQ/issues/1467

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
solarpenguin
Posts: 2
Joined: Tue Jul 03, 2018 10:30 pm

Re: href not re-writing URL

Post by solarpenguin »

Great. Thanks Thorsten! Happy to help where I can.
Xperanza
Posts: 3
Joined: Tue Jan 12, 2021 6:02 am

Re: href not re-writing URL

Post by Xperanza »

How do I fix this in version 2.9.x?
Thorsten
Posts: 15373
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: href not re-writing URL

Post by Thorsten »

Hi,

please update to v3.0 as v2.9 is out of support for a year now.

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
Xperanza
Posts: 3
Joined: Tue Jan 12, 2021 6:02 am

Re: href not re-writing URL

Post by Xperanza »

I have been using an original design template since version 2.8,
but version 3.0 is incompatible with templates, so I use version 2.9.
Can you do something about it?
Thorsten
Posts: 15373
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: href not re-writing URL

Post by Thorsten »

Hi,

you can try to patch your v2.9 installation with the fix:

https://github.com/thorsten/phpMyFAQ/co ... 6f08669c1f

But I would really recommend to upgrade to v3.0, v3.1 will be out soon.

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
Xperanza
Posts: 3
Joined: Tue Jan 12, 2021 6:02 am

Re: href not re-writing URL

Post by Xperanza »

In version 2.9, I fixed artikel.php and inc/PMF/Helper/Faq.php and it worked fine.
Thank you very much.
Thorsten
Posts: 15373
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: href not re-writing URL

Post by Thorsten »

Hi,

thanks for the feedback!

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
Post Reply