xhtml error within inc/News.php in pmf-2.5.0-dev

Please report bugs here!

Moderator: Thorsten

Post Reply
ZyanKLee
Posts: 5
Joined: Sat Feb 16, 2008 3:51 pm

xhtml error within inc/News.php in pmf-2.5.0-dev

Post by ZyanKLee »

Hey,

per definition "id" tags in xhtml/css are only allowed once per page.
in pmf-2.5.0-dev there is a id="goNews" every time a new news is displayed.
This brakes W3C-validity - I would suggest to apply the following patches:

Code: Select all

--- inc/News.php.old    2008-02-16 15:52:36.000000000 +0100
+++ inc/News.php        2008-02-16 15:48:04.000000000 +0100
@@ -170,7 +170,7 @@
             if (isset($item['header'])) {
                 $oLink->itemTitle =$item['header'];
             }
-            $output .= sprintf('<h3><a name="news_%d" href="%s">%s <img id="goNews" src="images/more.gif" width="11" height="11" alt="%s" /></a></h3><div class="block">%s',
+            $output .= sprintf('<h3><a name="news_%d" href="%s">%s <img class="goNews" src="images/more.gif" width="11" height="11" alt="%s" /></a></h3><div class="block">%s',
                             $item['id'],
                             $oLink->toString(),
                             $item['header'],

Code: Select all

--- template/style.rtl.css.old  2008-02-16 15:54:18.000000000 +0100
+++ template/style.rtl.css      2008-02-16 15:46:36.000000000 +0100
@@ -364,7 +364,7 @@
     float: left;
     margin-top: -16px;
 }
-.main-content #news img#goNews {
+.main-content #news img.goNews {
     border: none;
 }
 .main-content #news .block {
Thorsten
Posts: 15725
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Post by Thorsten »

Hi,

fixed in CVS. Thanks for the hint.

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
ZyanKLee
Posts: 5
Joined: Sat Feb 16, 2008 3:51 pm

Post by ZyanKLee »

You're welcome.

I think pmf is the best FAQ out there ... please keep up the good work.
Post Reply