2.6.2 | Email Issue

In this board you can talk about general questions about phpMyFAQ

Moderator: Thorsten

Post Reply
rdb3
Posts: 21
Joined: Fri Jan 29, 2010 7:03 pm

2.6.2 | Email Issue

Post by rdb3 »

Sending email from "Send to a Friend" does not include the sender's address in 2.6.2 (worked fine in 2.6.1).

Email clients respond differently. Outlook simply leaves the "From" blank while Gmail will show "(unkown sender)".

In either case, the emails will likely land in the Spam or Junk folders.

Thanks for your help with this issue.
Thorsten
Posts: 15724
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: 2.6.2 | Email Issue

Post by Thorsten »

HI,

we didn't changed anything here in 2.6.2. I checked it and it works on my test installations.

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
rdb3
Posts: 21
Joined: Fri Jan 29, 2010 7:03 pm

Re: 2.6.2 | Email Issue

Post by rdb3 »

It is happening so perhaps we should copy again the files that that function uses. Which ones are they?
Thorsten
Posts: 15724
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: 2.6.2 | Email Issue

Post by Thorsten »

HI,

it's inc/Mail.php

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
rdb3
Posts: 21
Joined: Fri Jan 29, 2010 7:03 pm

Re: 2.6.2 | Email Issue

Post by rdb3 »

Thanks! I just copied the mail.php from 2.6.1 and it resolves the problem. Will diff the mail.php from 2.6.1 with mail.php 2.6.2 and report back.
rdb3
Posts: 21
Joined: Fri Jan 29, 2010 7:03 pm

Re: 2.6.2 | Email Issue

Post by rdb3 »

I performed a diff on the mail.php 2.6.1 and mail.php 2.6.2

Here are the results. This code is in the //From section. The difference is found beginning on Line # 435.

2.6.1

Code: Select all

 $this->headers['From'] = (empty($name) ? '' : $name.' ').'<'.$address.'>';
2.6.2

Code: Select all

            if (empty($name)) {
                $this->headers['From'] ='';
            } else {
                if (function_exists('mb_encode_mimeheader')) {
                    $name = mb_encode_mimeheader($name);
                } else {
                    $name = encode_iso88591($name);
                }
                $this->headers['From'] =  $name .' <'.$address.'>';
            }
2.6.1 works (for us) but 2.6.2 produces an empty "From:" in the email sent (for us).

We use SMTP on IIS.

Hope this helps.
Thorsten
Posts: 15724
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: 2.6.2 | Email Issue

Post by Thorsten »

Hi,

you're right. I'll fix this for 2.6.3.

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
Post Reply