Help screen does not work in 1.3.13

AndrewB · Post by **AndrewB** » Tue May 25, 2004 2:45 am

Did I mess something up while customizing it or does the Help screen not work in 1.3.13 ?

I upgraded from 1.3.9 to 1.3.13

It looks like the Index.php file was changed and the code says that "Help" is valid. But my action is "Hilfe"

I just changed index.php to say "hilfe" => 1 and now it works again.

Post by **Thorsten** » Tue May 25, 2004 6:41 am

Hi,

this is a bug in 1.3.13, a new 1.3.14 will be available soon. And a 1.4.0 beta1

bye
Thorsten

AndrewB · Post by **AndrewB** » Fri May 28, 2004 9:12 pm

Another bug I noticed in 1.3.13 is that BB code tags don't work inside a code tag.

so if I have a big code block any bold tags inside it, the bold tags display as <b>Header</b>

Post by **Thorsten** » Sat May 29, 2004 7:03 am

This is a primary problem of the current BBCode implementation. Due to the fact that I dropped the whole BBCode support in 1.4.0 I won't write a complete new BBCode parser for 1.3.x. anymore. The new WYSIWYG editor is doing that better.

bye
Thorsten

AndrewB · Post by **AndrewB** » Sat May 29, 2004 11:07 am

it was working fine in all previous versions I used. maybe I will look at the code to see what changed..

thanks anyway. looking forward to 1.4

Post by **Thorsten** » Sat May 29, 2004 11:09 am

AndrewB wrote:it was working fine in all previous versions I used. maybe I will look at the code to see what changed..

Really?

bye
Thorsten

AndrewB · Post by **AndrewB** » Mon May 31, 2004 11:20 am

Yes!

Here is my test FAQ from 1.3.9
http://www.myie2info.com/testfaq/index. ... 16&lang=en

here is the current one from 1.3.13
http://www.myie2info.com/faq/index.php? ... 16&lang=en

It seems that the current one translates the "less than" "<" and "greater than" ">" characters to "<" and ">" but the 1.3.9 version did not do that.

AndrewB · Post by **AndrewB** » Mon May 31, 2004 11:28 am

maybe it has been affected by the backup and restore process? (just guessing)

Nope - not the save and restore. I just added a new entry in my test FAQ and the bold formatting works inside the <pre> tag. but in 1.3.13 it no longer works.

Post by **Thorsten** » Mon May 31, 2004 11:49 am

Hi,

I'd make a diff of both versions. There was a change inside the function code_syntax(), which affects your problem. Please change the 1.3.13 version of the function and use this version:

Code: Select all

/*
 * Funktion fÃ¼r BB-Code | @@ Meikel Katzengreis, 2003-07-23
 * Last Update: @@ Thorsten, 2004-01-20
 */
function code_syntax($output)
{
    $ret = $output[1];
    $ret = wordwrap($ret, 120, "\n", 0);
    $ret = htmlspecialchars($ret);
    return "<pre>".$ret."</pre>";
}

bye
Thorsten

AndrewB · Post by **AndrewB** » Mon May 31, 2004 12:13 pm

thanks for looking into this Thorsten

The code you posted was from the 1.3.13 version. Here is the code from the 1.3.9 version. I made the change and it works again

Code: Select all

/*
 * Funktion fÃ¼r BB-Code | @@ Meikel Katzengreis, 2003-07-23
 * Last Update: @@ Thorsten, 2003-07-23
 */
function code_syntax($output)
{
    $ret = $output[1];
    $ret = wordwrap($ret, 120, "\n", 0);
    $ret = unhtmlentities($ret);
    return "<pre>".$ret."</pre>";
}

Post by **Thorsten** » Mon May 31, 2004 12:14 pm

oops, sorry!

bye
Thorsten