revisions

[jazcyk]

I see that Thorsten plans to release 1.6 RC in a weeks time. I request a few details about revisions (that I now studied more in detail): I think 1) below should be in 1.6 RC (for easy upgrade in the future). 2)+3) could be later, though I also find 3) rather important.

1) Revisions are displayed as 'a.x'. A is always =1; x increments. I see that the database only holds the x value. a=1 must be hard-coded then. Actually I request that database has a revision_major (=a) and a revision_minor (=x). It would be OK for me, If I manually should access the database and change from 1.12 to 2.1, but a frontend implementation of course would be more in the 'spirit' of phpmyfaq. However that can be added later.

2) I request that faq_changes table gets a new column 'revision'. The (new - if a new revision is created) revision no. shall be written here . (NB: this was edited)

3) When deleting an article from the FAQ I see that entries in table faqdata_revisisons also are deleted. I think that should be optional. And ideally it should take a special privilege to be able to delete from faqdata_revisions table. Actually I think it would be better if the one deleted was copied to revisions table! Or even better that the revisons table always had the latest post from data table with a specific revision number.

4) The faqdata_revisions table has a column 'solution id'. Was it not better to use the 'id' from data table instead of 'solution_id' ? I might change the solution ID (admin panel lets me).

[Thorsten]

Hi,

first, the RC won't be released in March because I have a lot to do at work...

1) Revisions are displayed as 'a.x'. A is always =1; x increments. I see that the database only holds the x value. a=1 must be hard-coded then. Actually I request that database has a revision_major (=a) and a revision_minor (=x). It would be OK for me, If I manually should access the database and change from 1.12 to 2.1, but a frontend implementation of course would be more in the 'spirit' of phpmyfaq. However that can be added later.

You're right and this is planned for a future version. Matteo and myself talked about a diff feature for 2.0, too. So another frontend could be done.

2) I request that faq_changes table gets a new column 'revision'. The (new - if a new revision is created) revision no. shall be written here . (NB: this was edited)

hm, good idea, this could be added before the release of the RC.

3) When deleting an article from the FAQ I see that entries in table faqdata_revisisons also are deleted. I think that should be optional. And ideally it should take a special privilege to be able to delete from faqdata_revisions table. Actually I think it would be better if the one deleted was copied to revisions table! Or even better that the revisons table always had the latest post from data table with a specific revision number.

I'm thinking about since some days and my solution seems to be that we won't deleting the revisions. You're idea to copy the last entry to the revision table is a really great idea.

4) The faqdata_revisions table has a column 'solution id'. Was it not better to use the 'id' from data table instead of 'solution_id' ? I might change the solution ID (admin panel lets me).

The ID could change in the future for a re-ordering function. The solution ID will always remain static. And for companies it's really a great feature because you only have to give the costumer the solution ID and the user has to enter the ID in the search field and get the answer.

bye
Thorsten

[jazcyk]

because I have a lot to do at work...

Holy Cow! Here is a German having a job! Does it hurt?

[Thorsten]

Hi,

Holy Cow! Here is a German having a job! Does it hurt?

I will survive...

bye
Thorsten

[jazcyk]

Hi - I can see you did some of this allready.

Could I ask to to post here (when you are sure that you are completely finished with details):

1) List of changed files.
2) 'Create Table' statement (MySQL version) for database tables that have been changed.
... all relative to 1.6 BETA.

I will then look into it one of the nearest days.

[Thorsten]

Hi,

here are the diffs:

http://lists.thinkforge.org/pipermail/p ... 00531.html
http://lists.thinkforge.org/pipermail/p ... 00533.html
http://lists.thinkforge.org/pipermail/p ... 00534.html
http://lists.thinkforge.org/pipermail/p ... 00535.html
http://lists.thinkforge.org/pipermail/p ... 00536.html

bye
Thorsten

[jazcyk]

and the changed files work fine. Though I still would prefer that major_revisions was implemented in the database ...

[Thorsten]

Hi,

and the changed files work fine. Though I still would prefer that major_revisions was implemented in the database ...

we'll add that in a later version.

bye
Thorsten