phpmyfaq sends email --> Link: port is missing

Please report bugs here!

Moderator: Thorsten

Post Reply
matteo
Posts: 572
Joined: Sun Nov 20, 2005 6:53 pm
Location: Italy

Post by matteo »

Hi,
do you mean a faq proposal? It's already fixed in CVS.

Regards,
Matteo
phpMyFAQ QA / Developer
Amazon.co.uk Wishlist
Thorsten
Posts: 15725
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Post by Thorsten »

Hi,

it is fixed in CVS. You can download the CVS snapshot and update auf pre-1.6.6.

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
matteo
Posts: 572
Joined: Sun Nov 20, 2005 6:53 pm
Location: Italy

Post by matteo »

Hi,
can you post what is the file you've changed plus the code change? Or are you simply using the CSV nightly built snapshot?

Regards,
Matteo
phpMyFAQ QA / Developer
Amazon.co.uk Wishlist
matteo
Posts: 572
Joined: Sun Nov 20, 2005 6:53 pm
Location: Italy

No secret at all: what you need is already in your hands!

Post by matteo »

Hi,
there's nothing secret since:
  1. PMF is written in plain PHP code;
  2. you can diff by your own PMF 1.6.5 source code against PMF 1.6.6-dev snapshot
  3. you can query by your own the CVS repo to search for all changes ;)!
I assume that others than the PMF Dev Team have secrets!

BTW, here is the change on the FAQ proposal page, [PATH_TO_PMFINSTALL]/save.php:

Code: Select all

 
@@ -70,7 +70,7 @@
     if (function_exists('mb_encode_mimeheader')) {
         $subject = mb_encode_mimeheader($subject);
     }
-    $body = unhtmlentities($PMF_LANG['msgMailCheck'])."\n".unhtmlentities($PMF_CONF['title']).": http://".$_SERVER['SERVER_NAME'].dirname($_SERVER['PHP_SELF']);
+    $body = unhtmlentities($PMF_LANG['msgMailCheck'])."\n".unhtmlentities($PMF_CONF['title']).": http://".$_SERVER['HTTP_HOST'].('80' == $_SERVER['SERVER_PORT']? '' : ':'.$_SERVER['SERVER_PORT']).dirname($_SERVER['PHP_SELF']);
     if (ini_get('safe_mode')) {
         mail($IDN->encode($PMF_CONF["adminmail"]), $subject, $body, implode("\r\n", $additional_header));
     } else {
Regards,
Matteo
phpMyFAQ QA / Developer
Amazon.co.uk Wishlist
matteo
Posts: 572
Joined: Sun Nov 20, 2005 6:53 pm
Location: Italy

Post by matteo »

Hi,
it should be nice if you'd report if that change is the real responsible of doubling the HTTP custom port or maybe you've done some mistakes trying to customize PMF code ;).

Regards,
Matteo
phpMyFAQ QA / Developer
Amazon.co.uk Wishlist
Post Reply