Tags and CAPS vs caps (v2.0.13)

[djbeefburger]

I don't know if this quite qualifies as a bug, but I found that when tags are added and capitalization isn't consistent, the tags end up being duplicated in faqtags and then also in the tag cloud...

My proposed fix is changing Tags.php line 217 from

Code: Select all

if (!in_array($tagging_name, $current_tags)) {

to

Code: Select all

if(!in_array(strtolower($tagging_name), array_map('strtolower', $current_tags))){

and line 252 from

Code: Select all

array_search($tagging_name, $current_tags));

to

Code: Select all

array_search(strtolower($tagging_name), array_map('strtolower', $current_tags)));

This will keep people from changing the capitalization of their existing tags unless they go into the DB... what do you think?

Cheers!

-Eric

(sorry I wasn't sure if this should go in the Proposals or the Bugs section... )

[Thorsten]

Hi,

this is a very good proposal.

I added your code to phpMyFAQ 2.0.14 and 2.5.0-beta.

Thanks!

bye
Thorsten