Glossary Delete Column lacks labels

[dajoker]

http://1.2.3.4/phpmyfaq/admin/index.php?action=glossary

When going to the URL above (fixed for a real environment) the list of created Glossary terms is present (neat feature, btw). This list is presented in a table whose final column lacks any labels. Also instead of a 'Delete' link to do the deletion there is only some text asking, 'Are you sure?". It would probably help usability if this column were labeled and if the Delet option said something like, 'Delete'. If we want to prompt the user to verify they are sure we could do so via JavaScript or something after clicking.

Thanks.

[Thorsten]

Hi,

I will improve the workflow here. You are right.

bye
Thorsten

[Thorsten]

Hi,

this is fixed in my git repo and will be fixed in the upcoming 2.6.6 release. Thanks for the hint!

bye
Thorsten

[dajoker]

Great! I'll need to figure out how to checkout the latest branch from there to get all of this in there. In the meantime I just changed mine in a way that seemed appropriate though I have only updated the one language file. What do you typically do in this case if you do not speak all 38 supported languages? Do you just put the English version or just leave English in its on its own and the others (from a quick test I did) default to English if there aren't other languages' versions?

./phpmyfaq/admin/glossary.main.php
76c76
> print sprintf("<thead><tr><th class=\"list\">%s</th><th class=\"list\">%s</th><th>%s</th></tr></thead>",
---
< print sprintf("<thead><tr><th class=\"list\">%s</th><th class=\"list\">%s</th><th>&nbsp;</th></tr></thead>",
78,79c78
> $PMF_LANG['ad_glossary_definition'],
> $PMF_LANG['ad_glossary_deletecolumn']);
---
< $PMF_LANG['ad_glossary_definition']);

and

./phpmyfaq/lang/language_en.php
1083a1084,1086
>
> // added 2.6.6 - 2010-05-29 by dajoker
> $PMF_LANG['ad_glossary_deletecolumn'] = 'Delete?';

[Thorsten]

Hi,

What do you typically do in this case if you do not speak all 38 supported languages? Do you just put the English version or just leave English in its on its own and the others (from a quick test I did) default to English if there aren't other languages' versions?

the English language file is base language file. If a string is missing in a translation we always fall back to English.

bye
Thorsten