2.7 Beta

Please report bugs here!

Moderator: Thorsten

Post Reply
jeffw
Posts: 23
Joined: Mon Jan 24, 2011 12:02 pm

2.7 Beta

Post by jeffw »

I've installed 2.7 beta and the searching seems to have changed. Various words if searched for no longer show results but they do on 2.6.15.

I've copied the PMF_Search folder to the 2.7 beta install and the search works as before.

What has changed in the new search? What will i lose out on if i revert back to the old search?

Cheers

Jeff
Thorsten
Posts: 15725
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: 2.7 Beta

Post by Thorsten »

Hi,

please explain exactly what has changed for you?

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
jeffw
Posts: 23
Joined: Mon Jan 24, 2011 12:02 pm

Re: 2.7 Beta

Post by jeffw »

Words exists as keywords, in the question and also in the answer. When i do a search i get no results on certain words. If i use version 2.6.15 it gives me the hits. If i copy PMF_Search folder and files to 2.7 beta i get hits on the searches as before.

'eat' was one of the words i can remember.
Thorsten
Posts: 15725
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: 2.7 Beta

Post by Thorsten »

Hi,

can I check this on your page?

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
jeffw
Posts: 23
Joined: Mon Jan 24, 2011 12:02 pm

Re: 2.7 Beta

Post by jeffw »

Ok, i've copied the 2.7 PMF_Search folder back so shows no hits.

[Link removed]

If i search for 'eat' or 'wbs' i get no hits using the new version, if i copy the previous PMF_Search folder across i do get hits as before.

Cheers

Jeff
Last edited by jeffw on Tue Jul 26, 2011 8:44 am, edited 1 time in total.
jeffw
Posts: 23
Joined: Mon Jan 24, 2011 12:02 pm

Re: 2.7 Beta

Post by jeffw »

I've added this bit of code which was in 2.6 back into mysql.php which seems to have fixed it.

Code: Select all

 // Fallback for searches with less than three characters
            if (0 == $this->dbHandle->num_rows($this->resultSet)) {
                
                $query = sprintf("
                    SELECT
                        %s
                    FROM 
                        %s %s %s
                    WHERE
                        %s
                        %s",
                    $this->getResultColumns(),
                    $this->getTable(),
                    $this->getJoinedTable(),
                    $this->getJoinedColumns(),
                    $this->getMatchClause($searchTerm),
                    $this->getConditions());
            }
            
            $this->resultSet = $this->dbHandle->query($query);
Thorsten
Posts: 15725
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: 2.7 Beta

Post by Thorsten »

Hi,

the code was missing in the MySQL driver, but is was present in the better MySQLi driver. I added the missing code fopr beta2.

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
jeffw
Posts: 23
Joined: Mon Jan 24, 2011 12:02 pm

Re: 2.7 Beta

Post by jeffw »

Just download the new mysql.php boolean fix from github. When using this version I experience the same issues. I've changed the following line back to previous code


// Fallback for searches with less than three characters
if (false == $this->resultSet) {

changed back to

if (false == $this->dbHandle->num_rows($this->resultSet)) {
Post Reply