Sitemap does not find Hebrew letters

Please report bugs here!

Moderator: Thorsten

Post Reply
IHaveYourMilk
Posts: 13
Joined: Sun May 19, 2013 8:16 am

Sitemap does not find Hebrew letters

Post by IHaveYourMilk »

Hey,

i noticed that when viewing the Sitemap in Hebrew,
no letters are found!

even if explicitly stating the Query string, no records are found.

best regards
"If you build it, it will come..."
IHaveYourMilk
Posts: 13
Joined: Sun May 19, 2013 8:16 am

Re: Sitemap does not find Hebrew letters

Post by IHaveYourMilk »

version 2.8.0

i think i found the problem:
1.
./inc/pmf/sitemap.php line 190
in method public function getAllFirstLetters()

Code: Select all

if (PMF_String::preg_match("/^[一-龠]+|[ぁ-ん]+|[ァ-ヴー]+|[a-zA-Z0-9]+|[a-zA-Z0-9]/i", $letters)) 
filters out the hebrew letters א-ת, ם, ן, ך, ף

2.
some of the letters gets blank because they take 2 bytes (utf8 encode) (e.g. ל, מ)

this might be nested in public function getRecordsFromLetter($letter = 'A')

Code: Select all

$letter = PMF_String::strtoupper($this->_config->getDb()->escape(PMF_String::substr($letter, 0, 1)));
but didn't see how to fix it properly.
"If you build it, it will come..."
Thorsten
Posts: 15724
Joined: Tue Sep 25, 2001 11:14 am
Location: #phpmyfaq
Contact:

Re: Sitemap does not find Hebrew letters

Post by Thorsten »

Hi,

thanks for the hint, I'll fix it with the characters you mentioned in 1)

bye
Thorsten
phpMyFAQ Maintainer and Lead Developer
amazon.de Wishlist
IHaveYourMilk
Posts: 13
Joined: Sun May 19, 2013 8:16 am

Re: Sitemap does not find Hebrew letters

Post by IHaveYourMilk »

Thanks,
for real, only א-ת are needed,
all the rest are finalizing letters that come only at the End of words.
"If you build it, it will come..."
Post Reply