Bug in 1.6.3 - Captcha off, but not gone

[parseljc]

Just installed 1.6.3 so I could turn off Captcha and the "safe" email re-write. (We are using an internal site and don't need these features.)

The Captcha is off but still displays this:

Code: Select all

{msgCaptcha}
        {printCaptcha} 
     ________________  
    [________________]

(That represents the blank input textfield it is still showing for me to enter the Captcha answer.)

[matteo]

Hi,
just installed a PMF 1.6.3 from scratch (if of any interest, using the new RPM option ) using an empty MySQL DB: I'm not able to reproduce your issue.
Could you post some more data such as:

• Have you done a fresh installation or a new update?
• In case of update, from which version?
• Which is your PMF server configuration?

[jazcyk]

doesn't it look like an issue with the 'gd2' php module?

[Thorsten]

Hi,

did you an update?

bye
Thorsten

[parseljc]

Sorry, I had done an update. I don't recall the previous version, it was probably 1.6.0. Before that I had 1.5.5.

I just updated from 1.6.3 to 1.6.6 and I still see the same box like I reported above.

Obviously what's happening is the template still contains template code to display the Captcha image and the answer input field, like so:

Code: Select all

    <fieldset>
    <legend>{msgCaptcha}</legend>
        <div style="text-align:center;">
            {printCaptcha}
            <input class="inputfield" style="vertical-align: top;" type="text" name="captcha" id="captcha" value="" size="{setCaptchaCodeLength}" />
        </div>
     </fieldset>

The captcha is turned off in the configuration, so it doesn't replace {msgCaptcha} and {printCaptcha} with the appropriate message and image, but shouldn't it also just remove that whole <fieldset> section from the page instead of printing it? If I view the source of the webpage, I see:

Code: Select all

    <fieldset>
    <legend>{msgCaptcha}</legend>
        <div style="text-align:center;">
            {printCaptcha}
            <input class="inputfield" style="vertical-align: top;" type="text" name="captcha" id="captcha" value="" size="{setCaptchaCodeLength}" />
        </div>
     </fieldset>

which is exactly the same as what's in the template.


Is it working like this for everyone else? Or if you turn off Captcha does the whole box go away completely?

[Thorsten]

Hi,

we changed some template files between 1.6.0 and 1.6.1 to make it possible to remove the captcha. Please use the changed template files.

bye
Thorsten

[parseljc]

Aha, I guess I didn't read the documentation carefully enough. I just saw the part that said to copy everything except the template/ directory.

Maybe it's me, but even after realizing that there is a section called "3.e. Modifying templates for phpMyFAQ 1.6.x" it is not clear that you have to modify the templates. For example, when I upgraded from 1.6.0 to 1.6.3, the documentation was identical to what it is now, and I did not understand based on what I read that I needed to make changes to the template files.

3.d is pretty clear that you should *not* copy in the template/ directory. I understand this is because people probably customized their templates and CSS files to integrate phpMyFAQ to the look and feel of the rest of their site, and you don't want them to overwrite those files.

Perhaps section 3.e could be re-written to make it clear that you need to merge in changes to the template files? Also, put a note at the end of each of the previous 3._ (a,b,c,d) sections that you also have to move on to 3.e and follow those instructions to make sure your templates are up-to-date.

3.e. Modifying templates for phpMyFAQ 1.6.x
The 1.3.x templates are not compatible with phpMyFAQ 1.6.x, so please take the default XHTML templates from the package. The 1.4.x templates are partly compatible with phpMyFAQ 1.6.x, so you have to edit them and add some new placeholders for the captcha support. The 1.5.x templates are mostly compatible with phpMyFAQ 1.6.x, if your layout is completly based on CSS, you only have to change the .tpl files listed in docs/CHANGEDFILES.txt. If you need help to integrate phpMyFAQ into your website feel free to contact us.

3.e. Modifying templates for phpMyFAQ 1.6.x
You must make modifications to your existing template files if they have changed since the release from which you are upgrading. Use CHANGEDFILES.txt to determine which template/ files have changed (if any).

The 1.3.x templates are not compatible with phpMyFAQ 1.6.x, so please take the default XHTML templates from the package. The 1.4.x templates are partly compatible with phpMyFAQ 1.6.x, so you have to edit them and add some new placeholders for the captcha support. The 1.5.x templates are mostly compatible with phpMyFAQ 1.6.x, if your layout is completly based on CSS, you only have to change the .tpl files listed in docs/CHANGEDFILES.txt. If you need help to integrate phpMyFAQ into your website feel free to contact us.

[matteo]

Hi,
that's correct IF no template file is listed in [PATH_TO_PMFINSTALL]/docs/CHANGEDFILES.txt

Regards,
Matteo