phpMyFAQ 2.0.0-RC2: Select All rights link doesn't work

[rickliveops]

The "select all" link in the User Administration page doesn't do anything.

Link: admin/index.php?action=user&user_action=update_data

I created a new user, and want to give them all rights. I click on the "Select All" link but nothing happens. I tried saving the user first then clicked Select All. Still nothing.

[Thorsten]

Hi,

yes, you're right. We'll fix that for the final release.

Thanks!

bye
Thorsten

[Thorsten]

Hi,

this bug is fixed in 2.0.0 and 2.1.0-dev. The nightly CVS snapshot for tomorrow includes the fix, here's the patch as diff:

Code: Select all

? functions.js.patch
Index: functions.js
===================================================================
RCS file: /cvsroot/phpmyfaq/phpmyfaq/inc/js/functions.js,v
retrieving revision 1.4
diff -u -r1.4 functions.js
--- functions.js	1 Oct 2006 13:44:59 -0000	1.4
+++ functions.js	14 May 2007 19:37:32 -0000
@@ -162,10 +162,9 @@
 function form_checkAll(form_id)
 {
     var inputElements = document.getElementById(form_id).getElementsByTagName('input');
-    for (var i = 0; i < inputElements.length; i++) {
-        var type = inputElements[i].getAttribute('type');
-        if ((type == "checkbox" || type == "CHECKBOX")) {
-            inputElements[i].setAttribute('checked', "checked");
+    for (var i = 0, ele; ele = inputElements[i]; i++) {
+        if (ele.type == "checkbox") {
+            ele.checked = true;
         }
     }
 }
@@ -181,11 +180,10 @@
 function form_uncheckAll(form_id)
 {
     var inputElements = document.getElementById(form_id).getElementsByTagName('input');
-    for (var i = 0; i < inputElements.length; i++) {
-        var type = inputElements[i].getAttribute('type');
-        if ((type == "checkbox" || type == "CHECKBOX") && inputElements[i].getAttribute('checked')) {
-            inputElements[i].removeAttributeNode(inputElements[i].getAttributeNode('checked'));
-        }
+    for (var i = 0, ele; ele = inputElements[i]; i++) {
+        if (ele.type == "checkbox") {
+            ele.checked = false;
+        } 
     }
 }
 

bye
Thorsten