PHP5?...

[jch02140]

Will phpMYFAQ version 2 completely redone using PHP5?...

[Thorsten]

Hi,

Will phpMYFAQ version 2 completely redone using PHP5?...

this is the plan...

phpMyFAQ 1.3.9 and later are already running with PHP5.

bye
Thorsten

[moj]

Just downloaded CVS version to test the Postgres implementation, but I didn't get too far.

I found a couple of problems i the db class:

1. I had to insert a str_replace to replace backslashes to be able to include correct database class.

2 More fatal, the reassign of $this is not allowed in php5 ($this = new $func();) I guess we need some refactoring of this.

I'm on winxp with Apache 2 and PostgreSQL 8 beta4.

/moj

[Thorsten]

Hi,

is it possible to send me your diffs from the current CVS? Thanks!

bye
Thorsten

[moj]

Still problems with php5... (CVS version from 2004-12-31)

I think the reassign of $this in the db class is illegal, in php5 $this is readonly.

This is my error message:
Fatal error: Cannot re-assign $this in P:\www\virtualhosts\phpmyfaq\inc\db.php on line 59

The only workaround I can think of is to disable the db class and use the pgsql or other db specific class instead.

Can someone suggest a more elegant solution to this?

[Thorsten]

Hi,

we need to rewrite the complete DB class to fix this PHP5 only problem. I'll try to do this the next days.

bye
Thorsten

[Thorsten]

Hi,

could you please test the current CVS version with PHP5. I rewrote some of the stuff.

bye
Thorsten

[moj]

Yes, this seems to fix the reassign $this problem

A few other problems (not related to php5) :
- I get doble linefeeds i all files. In some cases this will lead to problems when ther ins an extra empty line at the end, after "?>", e.g. in db.php and category.php. Maybe this could have something to dio with my CVS client Tortoise?

- Add user with some debug lines:
Debug - function nextID($table, $id)
Debug - query: SELECT max(id) as current_id FROM faquser
Debug - $result: Resource id #20
Debug - num rows: 1

Warning: pg_result() [function.pg-result]: Unable to jump to row 1 on PostgreSQL result index 20 in P:\www\virtualhosts\phpmyfaq\inc\pgsql.php on line 377

I can't se anything wrong with the query. Have also tried with function pg_fetch_result. Still same problem...

/moj

[Thorsten]

Hi,

I don't have double line feeds and I use Tortoise, too. Your reported bug is fixed in CVS.

bye
Thorsten

[moj]

...
Warning: pg_result() [function.pg-result]: Unable to jump to row 1 on PostgreSQL result index 20 in P:\www\virtualhosts\phpmyfaq\inc\pgsql.php on line 377
...

Solution

Line 377 in inc\pgsql.php:
$currentID = pg_result($result, 1, 'current_id');
change to:
$currentID = pg_result($result, 0, 'current_id');

Row numbering starts from 0 according to docs.

[Thorsten]

Hi,

thanks, it's fixed in CVS.

bye
Thorsten